Implement CodeRabbit's feedback

Author: max-svistunov

src/app/endpoints/query.py

@@ -78,14 +78,17 @@
             }
         ],
     },
-    400: {
+    401: {
         "description": "Missing or invalid credentials provided by client",
         "model": UnauthorizedResponse,
     },
     403: {
         "description": "User is not authorized",
         "model": ForbiddenResponse,
     },
+    404: {
+        "description": "Requested model or provider not found",
+    },
     500: {
         "detail": {
             "response": "Unable to connect to Llama Stack",

tests/e2e/features/query.feature

@@ -59,41 +59,47 @@ Feature: Query endpoint API tests
           {"detail": "No Authorization header found"}
           """
 
-  Scenario: Check if LLM responds to sent question with error when not authenticated with invalid token
+  Scenario: Check if LLM responds to sent question with error when authenticated with invalid token
+    Given The service is started locally
+    And REST API service prefix is /v1
     Given The system is in default state
     And I set the Authorization header to Bearer invalid
     When I use "query" to ask question with authorization header
-     """
-     {"query": "Write a simple code for reversing string"}
-     """
-      Then The status code of the response is 401
-      And The body of the response is the following
-          """
-          {"detail":"Invalid token: decode error"}
-          """
+      """
+      {"query": "Write a simple code for reversing string"}
+      """
+    Then The status code of the response is 401
+    And The body of the response is the following
+      """
+      {"detail":"Invalid token: decode error"}
+      """
 
   Scenario: Check if LLM responds to sent question with error when model does not exist
+    Given The service is started locally
+    And REST API service prefix is /v1
     Given The system is in default state
     And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
     When I use "query" to ask question with authorization header
-     """
-     {"query": "Write a simple code for reversing string", "model": "does-not-exist", "provider": "does-not-exist"}
-     """
-      Then The status code of the response is 404
-      And The body of the response contains Model does-not-exist from provider does-not-exist not found in available models
-
+      """
+      {"query": "Write a simple code for reversing string", "model": "does-not-exist", "provider": "does-not-exist"}
+      """
+    Then The status code of the response is 404
+    And The body of the response contains Model does-not-exist from provider does-not-exist not found in available models
 
   Scenario: Check if LLM responds to sent question with error when attempting to access conversation
+    Given The service is started locally
+    And REST API service prefix is /v1
     Given The system is in default state
-     And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
-     When I use "query" to ask question with authorization header
-     """
-     {"conversation_id": "123e4567-e89b-12d3-a456-426614174000", "query": "Write a simple code for reversing string"}
-     """
-      Then The status code of the response is 404
-      And The body of the response contains Conversation not found
+    And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
+    When I use "query" to ask question with authorization header
+      """
+      {"conversation_id": "123e4567-e89b-12d3-a456-426614174000", "query": "Write a simple code for reversing string"}
+      """
+    Then The status code of the response is 404
+    And The body of the response contains Conversation not found
+
+  Scenario: Check if LLM responds for query request with error for missing query
 
-Scenario: Check if LLM responds for query request with error for missing query
     Given The system is in default state
      And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
      When I use "query" to ask question with authorization header