Merge pull request #1713 from lightninglabs/update-golang-version

Roasbeef · web-flow · commit 17da06e16926 · 2025-08-07T16:33:55.000-07:00
mod: update Golang version to v1.23.12 to fix potential SQL bug
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -19,7 +19,7 @@ env:
   # go needs absolute directories, using the $HOME variable doesn't work here.
   GOPATH: /home/runner/work/go
 
-  GO_VERSION: '1.23.9'
+  GO_VERSION: '1.23.12'
   
   LITD_ITEST_BRANCH: 'tapd-main-branch'
 
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -10,7 +10,7 @@ defaults:
     shell: bash
 
 env:
-  GO_VERSION: 1.23.9
+  GO_VERSION: 1.23.12
 
 jobs:
   main:
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.9-alpine as builder
+FROM golang:1.23.12-alpine as builder
 
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.
diff --git a/Makefile b/Makefile
@@ -57,7 +57,7 @@ DOCKER_TOOLS = docker run \
   -v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \
   -v $$(pwd):/build taproot-assets-tools
 
-GO_VERSION = 1.23.9
+GO_VERSION = 1.23.12
 
 GREEN := "\\033[0;32m"
 NC := "\\033[0m"
diff --git a/dev.Dockerfile b/dev.Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.9 as builder
+FROM golang:1.23.12 as builder
 
 WORKDIR /app
 
diff --git a/docs/examples/basic-price-oracle/go.mod b/docs/examples/basic-price-oracle/go.mod
@@ -1,6 +1,6 @@
 module basic-price-oracle
 
-go 1.23.9
+go 1.23.12
 
 // We want to format raw bytes as hex instead of base64. The forked version
 // allows us to specify that as an option.
diff --git a/docs/release-notes/release-notes-0.7.0.md b/docs/release-notes/release-notes-0.7.0.md
@@ -183,6 +183,9 @@
 
 ## Code Health
 
+- [The Golang version used was bumped to `v1.23.12` to fix a potential issue
+  with the SQL API](https://github.com/lightninglabs/taproot-assets/pull/1713).
+
 ## Tooling and Documentation
 
 - [Two new sequence diagrams were
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/lightninglabs/taproot-assets
 
-go 1.23.9
+go 1.23.12
 
 require (
 	github.com/btcsuite/btcd v0.24.3-0.20250318170759-4f4ea81776d6
diff --git a/itest/loadtest/Dockerfile b/itest/loadtest/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.9 as builder
+FROM golang:1.23.12 as builder
 
 WORKDIR /app
 
diff --git a/make/builder.Dockerfile b/make/builder.Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.9-bookworm
+FROM golang:1.23.12-bookworm
 
 MAINTAINER Olaoluwa Osuntokun <laolu@lightning.engineering>
 
diff --git a/scripts/check-release-notes.sh b/scripts/check-release-notes.sh
@@ -7,11 +7,11 @@ set -e
 PR_NUMBER=$(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }')
 
 # If this is a PR being merged into the main repo, then the PR number will
-# actually be "master" here, so we'll ignore this case, and assume that in
+# actually be "main" here, so we'll ignore this case, and assume that in
 # order for it to be merged it had to pass the check in its base branch. If
 # we're trying to merge this with the Merge Queue, then the PR number will be
 # "gh-readonly-queue" instead.
-if [[ $PR_NUMBER == "master" ]] || [[ $PR_NUMBER == "gh-readonly-queue" ]]; then
+if [[ $PR_NUMBER == "main" ]] || [[ $PR_NUMBER == "gh-readonly-queue" ]]; then
     exit 0
 fi
 
diff --git a/taprpc/Dockerfile b/taprpc/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.9-bookworm
+FROM golang:1.23.12-bookworm
 
 RUN apt-get update && apt-get install -y \
   git \
diff --git a/taprpc/go.mod b/taprpc/go.mod
@@ -1,6 +1,6 @@
 module github.com/lightninglabs/taproot-assets/taprpc
 
-go 1.23.9
+go 1.23.12
 
 require (
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
diff --git a/tools/Dockerfile b/tools/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.9-bookworm
+FROM golang:1.23.12-bookworm
 
 RUN apt-get update && apt-get install -y git
 ENV GOCACHE=/tmp/build/.cache
diff --git a/tools/go.mod b/tools/go.mod
@@ -1,8 +1,6 @@
 module github.com/lightninglabs/taproot-assets/tools
 
-go 1.23.0
-
-toolchain go1.23.7
+go 1.23.12
 
 require (
 	github.com/btcsuite/btcd v0.24.2

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.23.9-alpine as builder`
	`1`	`+FROM golang:1.23.12-alpine as builder`
`2`	`2`
`3`	`3`	`# Force Go to use the cgo based DNS resolver. This is required to ensure DNS`
`4`	`4`	`# queries required to connect to linked containers succeed.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.23.9 as builder`
	`1`	`+FROM golang:1.23.12 as builder`
`2`	`2`
`3`	`3`	`WORKDIR /app`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.23.9-bookworm`
	`1`	`+FROM golang:1.23.12-bookworm`
`2`	`2`
`3`	`3`	`MAINTAINER Olaoluwa Osuntokun <[email protected]>`
`4`	`4`