Skip to content

Conversation

@guggero
Copy link
Collaborator

@guggero guggero commented May 31, 2023

As a preparation for making the tool part of the Lightning Labs tool suite, we rename the Golang module and all import paths.

To help users find out what commands they need to run we also update the README with more information.

```shell
$ cd /tmp
$ wget -O chantools.tar.gz https://github.com/guggero/chantools/releases/download/v0.10.7/chantools-linux-amd64-v0.10.7.tar.gz
$ wget -O chantools.tar.gz https://github.com/lightninglabs/chantools/releases/download/v0.11.2/chantools-linux-amd64-v0.11.2.tar.gz

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ gh release download -p '*linux*' -p 'manifest-*'

will download the latest release if the user has gh installed. If wanting to avoid new binaries could use: https://gist.github.com/steinwaywhw/a4cd19cda655b8249d908261a62687f8 though it might be outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note to the version in the cmd/chantools/root.go file that we don't forget to update this string. Probably easier than assuming what tools the user has installed.

@guggero guggero force-pushed the handover-fixups branch from 8a5d57f to 96cb596 Compare June 2, 2023 10:22
Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

I tested building and running a release.

I pushed a fixup commit to add doublespendinputs to the readme as well sputn1ck@04c425b

@guggero guggero force-pushed the handover-fixups branch from 96cb596 to e6a9395 Compare June 2, 2023 11:02
@guggero
Copy link
Collaborator Author

guggero commented Jun 2, 2023

I pushed a fixup commit to add doublespendinputs to the readme as well sputn1ck@04c425b

Thanks, I applied that fixup commit!

@guggero guggero merged commit 9fbec87 into master Jun 2, 2023
@guggero guggero deleted the handover-fixups branch June 2, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants