Skip to content

Remove background processor macro and parallelize persistence #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2025
Merged

Remove background processor macro and parallelize persistence #3968

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d749ccd
Expand background processor define_run_body! macro
joostjager Jul 28, 2025
ff01967
Clean up macro expansion
joostjager Jul 28, 2025
e15f6a3
Dedup terminating log
joostjager Jul 28, 2025
fa02602
Introduce check_sleeper helper
joostjager Jul 28, 2025
ec8e1ca
Re-order async background processor tasks
joostjager Jul 29, 2025
269cff7
Remove unnecessary Copy bound from MultiResultFuturePoller
joostjager Jul 28, 2025
d9a6641
Parallelize persistence in the async bg processor
joostjager Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lightning-background-processor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,6 @@ where
last_forwards_processing_call = sleeper(cur_batch_delay);
}
if should_break {
log_trace!(logger, "Terminating background processor.");
Copy link
Contributor

@tnull tnull Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think I liked the previous behavior (logging this when initiating the shutdown process) a bit better.

Copy link
Contributor Author

@joostjager joostjager Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it changed. We are still logging before we do the final persist round. The only difference is logging before or after the break.

break;
}

Expand Down Expand Up @@ -819,7 +818,6 @@ where
false
};
if should_break {
log_trace!(logger, "Terminating background processor.");
break;
}
if channel_manager.get_cm().get_and_clear_needs_persistence() {
Expand Down Expand Up @@ -1031,6 +1029,7 @@ where
last_sweeper_call = sleeper(SWEEPER_TIMER);
}
}
log_trace!(logger, "Terminating background processor.");

// After we exit, ensure we persist the ChannelManager one final time - this avoids
// some races where users quit while channel updates were in-flight, with
Expand Down