-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set maximum total fees during routing #2339
Comments
We definitely should, but applying this is a bit complicated, at least on the outbound_payment end - we'll need to figure out how much of our budget is left every time we go to retry, and will run the risk of "over-spending" on one path and then running out entirely on another retry. At least on the routing end its probably not that hard to apply, though there's no way to set a total limit on a secondary metric in dijkstras without spuriously failing, but hopefully its low enough risk it doesn't matter. |
As stated in #2409:
|
Turned out to be a bit bigger of a refactor than we could fit inside 116, but definitely need to get it in in 117. |
We should give users the capability of setting a hard cap for the routing fees, e.g, through
PaymentParameters::max_total_routing_fee
or similar.This might also go hand-in-hand with #495, as such an upper bound might give us some indication of a privacy budget we're allowed to spend on finding more reliable or more random routes.
The text was updated successfully, but these errors were encountered: