New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction sync crate follow-ups #2010

Closed

3 tasks done

tnull opened this issue Feb 4, 2023 · 1 comment · Fixed by #2685

Closed

3 tasks done

Transaction sync crate follow-ups #2010

tnull opened this issue Feb 4, 2023 · 1 comment · Fixed by #2685

Contributor

tnull commented Feb 4, 2023 •

edited

Loading

After the Esplora and Electrum variants have been merged, we should:

Reconsider if we want a variant enabled by default, or if all remain opt-in via features.
Clean up the error types and expose more of the underlying errors through sensible unified types (no wrapping)
DRY up some of the sync logic/error handling, see Add transaction sync crate #1870 (comment)

tnull mentioned this issue

Add transaction sync crate #1870

Merged

Collaborator

TheBlueMatt commented Feb 4, 2023

Also reduce the MSRV, ideally to 1.48 or lower so we can include it in bindings as an option (probably only the sync version).

tnull mentioned this issue

Add electrum support to lightning-transaction-sync #2685

Merged

TheBlueMatt closed this as completed in #2685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment