Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user that they need to shutdown when Persist functions start returning failures #1424

Open
johncantrell97 opened this issue Apr 15, 2022 · 0 comments

Comments

@johncantrell97
Copy link
Contributor

There's a TODO in the Persist implementation provided that says:

// TODO: We really need a way for the persister to inform the user that its time to crash/shut
// down once these start returning failure.
// A PermanentFailure implies we need to shut down since we're force-closing channels without
// even broadcasting!

@TheBlueMatt thinks using Event::ChannelClosed here might make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant