fixup! Add end-to-end test for HRN resolution (include hook for switching test offers)

We use a hook to switch the test offer for the offer returned after dnsssec resolution.

Author: chuksys

src/lib.rs

@@ -1604,3 +1604,33 @@ pub(crate) fn total_anchor_channels_reserve_sats(
 			* anchor_channels_config.per_channel_reserve_sats
 	})
 }
+
+/// Testing utils for DNSSEC proof resolution of offers associated with the given HRN.
+pub mod dnssec_testing_utils {
+	use lightning::offers::offer::Offer;
+	use lightning::onion_message::dns_resolution::HumanReadableName;
+
+	use std::collections::HashMap;
+	use std::sync::{LazyLock, Mutex};
+
+	static OFFER_OVERRIDE_MAP: LazyLock<Mutex<HashMap<HumanReadableName, Offer>>> =
+		LazyLock::new(|| Mutex::new(HashMap::new()));
+
+	/// Sets a testing override for DNSSEC proof resolution of offers associated with the given HRN
+	pub fn set_testing_dnssec_proof_offer_resolution_override(hrn: &str, offer: Offer) {
+		OFFER_OVERRIDE_MAP
+			.lock()
+			.unwrap()
+			.insert(HumanReadableName::from_encoded(hrn).unwrap(), offer);
+	}
+
+	/// Retrieves a testing override for DNSSEC proof resolution of offers associated with the given HRN.
+	pub fn get_testing_offer_override(hrn: Option<HumanReadableName>) -> Option<Offer> {
+		OFFER_OVERRIDE_MAP.lock().unwrap().get(&hrn?).cloned()
+	}
+
+	/// Clears all testing overrides for DNSSEC proof resolution of offers.
+	pub fn clear_testing_overrides() {
+		OFFER_OVERRIDE_MAP.lock().unwrap().clear();
+	}
+}

src/payment/bolt12.rs

@@ -194,6 +194,18 @@ impl Bolt12Payment {
 			return Err(Error::NotRunning);
 		}
 
+		let owned_override_storage: Option<Offer> =
+			crate::dnssec_testing_utils::get_testing_offer_override(hrn.clone());
+
+		let offer: &Offer = match &owned_override_storage {
+			#[cfg(test)]
+			Some(overridden_offer) => {
+				log_info!(self.logger, "Using test-specific Offer override.");
+				overridden_offer
+			},
+			_ => offer,
+		};
+
 		let offer = maybe_deref(offer);
 
 		let mut random_bytes = [0u8; 32];

tests/integration_tests_rust.rs

@@ -30,7 +30,7 @@ use ldk_node::payment::{
 	ConfirmationStatus, PaymentDetails, PaymentDirection, PaymentKind, PaymentStatus,
 	UnifiedPaymentResult,
 };
-use ldk_node::{Builder, DynStore, Event, NodeError};
+use ldk_node::{dnssec_testing_utils, Builder, DynStore, Event, NodeError};
 use lightning::ln::channelmanager::PaymentId;
 use lightning::routing::gossip::{NodeAlias, NodeId};
 use lightning::routing::router::RouteParametersConfig;
@@ -1554,13 +1554,15 @@ async fn unified_send_to_hrn() {
 		std::thread::sleep(std::time::Duration::from_millis(10));
 	}
 
-	//let offer = node_b.bolt12_payment().receive(1000000, "test offer", None, None).unwrap();
-	//println!("offer! {:?}", offer.to_string());
+	let test_offer = node_b.bolt12_payment().receive(1000000, "test offer", None, None).unwrap();
 
 	// Sleep one more sec to make sure the node announcement propagates.
 	std::thread::sleep(std::time::Duration::from_secs(1));
 
 	let hrn = "[email protected]";
+
+	dnssec_testing_utils::set_testing_dnssec_proof_offer_resolution_override(hrn, test_offer);
+
 	let offer_payment_id: PaymentId = match node_a.unified_payment().send(&hrn, None).await {
 		Ok(UnifiedPaymentResult::Bolt12 { payment_id }) => {
 			println!("\nBolt12 payment sent successfully with PaymentID: {:?}", payment_id);