Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 04: tlv_payload description is not clear #800

Closed
bitonic-cjp opened this issue Sep 9, 2020 · 2 comments · Fixed by #801
Closed

BOLT 04: tlv_payload description is not clear #800

bitonic-cjp opened this issue Sep 9, 2020 · 2 comments · Fixed by #801

Comments

@bitonic-cjp
Copy link
Contributor

First of all, apparently TLV stands for Type Length Value, which was not immediately obvious to me. I guess the format is a sequence of one or more {type, length, value} fields - it would be nice to specify this explicitly.

Secondly, it doesn't specify the size of the type and length fields. Since earlier text claims that the minimum tlv_payload length is two bytes, I guess that's one byte for type, one byte for length and zero bytes for value (if length == 0)? If I need to guess, it's an indication the spec lacks some clarity.

@t-bast
Copy link
Collaborator

t-bast commented Sep 9, 2020

Does the section here answer these questions?

We may be missing a link from bolt 4 to bolt 1 to reference that section, feel free to add one where it would have made sense for you.

@cdecker
Copy link
Collaborator

cdecker commented Oct 9, 2020

I think this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants