Add arbitrary configuration settings to liftoffrc #174
Conversation
| @@ -0,0 +1,23 @@ | |||
| module Xcodeproj | |||
| class Project | |||
| def set_project_settings(key, value) | |||
There was a problem hiding this comment.
Are you adding a new method to this class? If so, could you extract this to a singleton method in another module/file that takes the project as its argument?
There was a problem hiding this comment.
This is a new method, yeah. I might just revert this, since it's not actually needed for this PR.
gfontenot
force-pushed
the
gf-arbitrary-settings
branch
from
dc1a0cc to
81bc691
Compare
| @@ -47,6 +47,27 @@ def add_script_phases(scripts) | |||
| end | |||
| end | |||
|
|
|||
| def perform_extra_config(extra_config) | |||
| if extra_config | |||
There was a problem hiding this comment.
Is extra_config a hash? Can it sometimes be nil? You may want to use the Hash() method: http://www.ruby-doc.org/core-2.1.3/Kernel.html#method-i-Hash
[1] pry(main)> Hash(nil)
=> {}
[2] pry(main)> Hash({})
=> {}
[3] pry(main)> Hash({k: 'v'})
=> {:k=>"v"}There was a problem hiding this comment.
It's actually set inside the config file. I was thinking about doing a refactor to make sure that a lot of these variables don't end up nil, but I'm not sure it's worth it since I'm considering porting the entire project to Swift.
This allows the user to set arbitrary build configurations on a per-build configuration basis. This is handled by the new `extra_config` key in `liftoffrc`.
gfontenot
force-pushed
the
gf-arbitrary-settings
branch
from
81bc691 to
f09e187
Compare
This allows the user to set arbitrary build configurations on a per-build
configuration basis. This is handled by the new
extra_configkey inliftoffrc.Fixes #142 #170 #160