Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically switch to verifying if no ARH is found #57

Closed
alevesely opened this issue Jan 17, 2016 · 4 comments
Closed

Automatically switch to verifying if no ARH is found #57

alevesely opened this issue Jan 17, 2016 · 4 comments
Assignees
Labels
bug Something isn't working enhancement Improvements or new features

Comments

@alevesely
Copy link

If there is no ARH, but an (unverified) DKIM-Signature exists, no verification is carried out. The following error sometimes is displayed, presumably due to an empty ARH.

2016-01-17 19:50:03 DKIM_Verifier.AuthVerifier ERROR Error: Parsing error (resource://dkim_verifier/ARHParser.jsm:249) JS Stack trace: [email protected]:249:1 < [email protected]:186:14 < [email protected]:161:21 < [email protected]:161:10 < _authVerifier_verify/promise<@AuthVerifier.jsm:103:17

@lieser
Copy link
Owner

lieser commented Jan 21, 2016

I can not confirm that with a non existing ARH no verification is carried out. Are you perhaps instead meaning an ARH header without a DKIM result in it? For this the verification is indeed not carried out. This behavior will be corrected.

About the parsing error:
Are you meaning with an empty ARH header something like Authentication-Results: or Authentication-Results: authserv-id;? This are not correct ARH headers. The correct way to indicate that no message authentication was done is Authentication-Results: authserv-id; none. Although this currently also produces an error (which will be corrected), it is not a paring error.
If you still think the ARH header which produces the parsing error is correct, please post it (or send it to [email protected]) so I can look into it in detail.

@lieser lieser self-assigned this Jan 21, 2016
@lieser lieser added bug Something isn't working enhancement Improvements or new features labels Jan 21, 2016
@alevesely
Copy link
Author

There is a silly:
Authentication-Results: tana.it; auth=pass (details omitted)
and there is a DKIM-Signature. It looks as if parsing throws an exception, so nothing else is going to be done. The status bar says "DKIM: No Signature", although there is one.

@lieser
Copy link
Owner

lieser commented Jan 21, 2016

Could you please send me the complete header that is giving the parsing error to [email protected]?

@lieser
Copy link
Owner

lieser commented Jan 21, 2016

The verification should now continue if the ARH header does not include a DKIM result. You can download a pre-release form https://github.com/lieser/dkim_verifier/releases.

@lieser lieser closed this as completed Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants