Compatibility with Thunderbird 78

[xsistema]

There exist a 4.0.0 pre-release there the main verification already works in TB 78. It is available for download at https://github.com/lieser/dkim_verifier/releases

The xpi can be downloaded under Assets at the bottom of each release.

Also note that the outdated Enigmail add-on can cause problems. Disable or remove the Enigmail add-on and restart Thunderbird to resolve this.

---

Installed today 3.1.0 version on TB 73.0b1. I see that add-on is installed - but on plugin manage page is just blank page. Also no action on TB mail panel - no text or menu available..

Error console messages:

ReferenceError: gDKIMOptionsGeneralPane is not defined options.xul:1:1
    onload chrome://dkim_verifier/content/options.xul:1
TypeError: textbox is null aboutAddonsExtra.js:44:25
    <anonymous> chrome://messenger/content/aboutAddonsExtra.js:44
SyntaxError: redeclaration of const THUNDERBIRD_THEME_PREVIEWS aboutAddonsExtra.js:1:1

[lieser]

Thanks a lot for reporting the problem. I will try to look into it this weekend, but can't promise anything.

[lieser]

Looks like TB removed the legacy XUL overlay loader this add-on still used. This mean the add-on needs to be converted into the new add-on type (MailExtensions). Which will probably not be something small.

I defiantly do plan to do this conversion into the new type. But you should not expect there to be a compatible version anytime soon.

[xsistema]

Don't let this great add-on die... Is there a big work involved due to TB change to version 75?

[lieser]

Like I said, I don't plan to let this add-on die, in fact I already started with the work a while ago.
Its just that this update will be something bigger. Especially since I'm trying to avoid any quick and dirty solutions, and instead invest more time to try improve the code quality while doing the update.

So unfortunately you will have to still wait some time. I will post here if there is a version ready there at least the basic works.

[lieser]

I have a very early version ready that you could start to try out: [email protected]

Note that only the basic DKIM verification works for now. Nothing else.
The resolver used is JSDNS. If you need to change the DNS server, you must do that via Thunderbird's config editor (bool pref extensions.dkim_verifier.dns.getNameserversFromOS and string pref extensions.dkim_verifier.dns.nameserver).

[xsistema]

Super, I can confirm it's working on TB75.0b3 (64-bit) Win10.

[hiasl360]

With TB 76.0b1 (64-Bit) macOs Version 4.0.0pre0 is not working. I get the following error console message:

Error: Incorrect argument types for dkimHeader.setDkimHeaderResult.

[xsistema]

The same on Win10 TB 76.0b1 (64-Bit)..

[lieser]

Thanks for letting me know, already noticed it will I worked on the porting today. Here is a new version that should work with TB 76 [email protected].

The version has the same limitations as the previous. Although the options page is now available again, the page doesn't work.

[xsistema]

Yes, it's working now on Win10 TB 76.0b1 (64-bit).

[lieser]

To lessen the amount of work needed for the migration of the add-on to a webextension, I'm thinking about dropping some features. If someone depends on any of the following, please let me know:

• account specific options
• showing the DKIM result in the status bar
• any of the add-ons hidden options, that can only be changed via TBs config editor

[xsistema]

I think most important is simply to see above the message DKIM test result (now it's working fine). Another good option would be to have an ability to create a filter - for example - From: ends with: ebay.com + DKIM is invalid (or missing) -> then: Move to Trash". I think these two options are the most important. Perhaps on mouse over warning icon (or OK icon - which does not exists yet) - would be nice to see more information, for example "Insecure signature algorithm: 2048 bits".

[DavidOsipov]

Also waiting to see the new version, that is compatible with Thunderbird 78

[lieser]

@DavidOsipov did you already try the last version I posted above?

I'm hoping to finish a new pre-release in the next few days, there at least most of the basic stuff and options work.
Unfortunately it will still take longer until the port to WebExtension is fully complete.

[DavidOsipov]

Thank you for your work! I installed it but my configuration of the Add-on is not being saved after I close the add-on configuration tab.
BTW, can I just ignore installing libunbound files to the Thunderbird's extensions folder, if there is a raspberry pi with unbound (maximum security + DNSSEC) + pi-hole (DNSSEC) in my local network?

[lieser]

I just published a new pre-release 4.0.0pre1 at https://github.com/lieser/dkim_verifier/releases. It still has some limitations (see release page), but it is a lot closer to the final state than the last version I uploaded here in this issue.

Please also start reporting and issues you see with with this verion (excluding the ones mentioned on the release page). Thanks.

@DavidOsipov

BTW, can I just ignore installing libunbound files to the Thunderbird's extensions folder, if there is a raspberry pi with unbound (maximum security + DNSSEC) + pi-hole (DNSSEC) in my local network?

Using the libunbound resolver needs a locally available libunbound library, regardless of the used DNS server.
But if you have a local DNSSEC aware server that you use as the DNS server, and you trust your local network (which I assume you do), you should be protected by DNSSEC with the default JSDNS resolver too.
You will however not get the DNSSEC indicator (https://github.com/lieser/dkim_verifier/wiki/Options#indicate-successful-dnssec-validation-with-a-lock-after-the-sdid) so see if the key was protected by DNSSEC.

Please create a separate issue if you have more questions about this.

[peci1]

I get this error with the prerelease version 4.0.0pre1 and TB 78.1.1:

aMsgHdr is null MimeMessage.jsm:185
    MsgHdrToMimeMessage resource:///modules/gloda/MimeMessage.jsm:185
    getFull chrome://messenger/content/parent/ext-messages.js:208
    getFull chrome://messenger/content/parent/ext-messages.js:206
    getFull self-hosted:844
    result resource://gre/modules/ExtensionParent.jsm:996
    withPendingBrowser resource://gre/modules/ExtensionParent.jsm:602
    result resource://gre/modules/ExtensionParent.jsm:996
    callAndLog resource://gre/modules/ExtensionParent.jsm:958
    recvAPICall resource://gre/modules/ExtensionParent.jsm:995
    AsyncFunctionNext self-hosted:693
DKIM_Verifier.background	FATAL	 Unexpected error during onMessageDisplayed Error: An unexpected error occurred background.mjs.js:169:7
    <anonymous> moz-extension://243dc715-800f-4257-9352-fded50b7a6b9/content/background.mjs.js:169

[lieser]

Thanks for the report, but I can not reproduce it. Can you please give more information?
E.g.:

• Does it happen with every email you view?
• Have you tried it with all other add-ons disabled?

Note that this could also be a potential bug in TB. This error seems to olny happen if browser.messages.getFull(messageId) gets called with an invalid messageId. But the id used by the add-on comes directly from TB itself.

[peci1]

I had the account set up to only download message headers. I've noticed the described error only happens with messages I downloaded during the current run of TB. If I download a message body and restart TB, switching to it doesn't generate any error. I've tried with all other addons off, and the behavior is the same.

[lieser]

Thanks for investigating the problem, with your info I could now reproduce it. Looks like a bug in TB to me, so I filled a bug for it: https://bugzilla.mozilla.org/show_bug.cgi?id=1659555. I also don't see an easy workaround, so lets hope it gets fixed quickly in TB itself.

[tranceptor]

Now this plugin is not compatible with the new 78.2.2 version of Thunderbird.
The plugin was automatically disabled.
Thank you.

[xsistema]

Thunderbird 81.0b4 64-bit Win OS version is the newest now.. and it's working fine.

[hagedose]

Now this plugin is not compatible with the new 78.2.2 version of Thunderbird.
The plugin was automatically disabled.

4.0.0pre1 works for me with TB 78.2.2
Are you sure you have that?

[lieser]

Question to all who used the key storing feature:
Did you use the creation and last used date that could be seen then viewing the keys for anything?
If yes, please let me know, as I'm considering to remove this to keep thinks more simple.

[leagris]

• DKIM_Verifier 4.0.0pre4
• Thunderbird 78.5.0 (64 bits) Ubuntu Linux 20.10

Issue encountered:

• Internal Error

background.mjs.js:164:7

DKIM_Verifier.background	FATAL	 Unexpected error during onMessageDisplayed Error: An unexpected error occurred

[lieser]

@leagris Thanks for reporting the error. Did you have debug enabled, and also saved the messages before the error?
And can you reproduce the issue?
If not, I unfortunately don't think I will be able to find the underlying issue (and fix it). This kind of errors sadly don't provide any information at all by them self.

[Railander]

i know i'm very late to this, but it's sad to see that the status bar icon was scrapped.
i find that the other options are too intrusive, either by reducing normal TB functionality or adding to visual polution.

i'd love to see the icon come back even if next to the "From" header, similar to the well-known signer Favicon icon, which speaking of also hasn't worked for me since the TB update that broke the add-on.

[lieser]

@Railander I created the separated issue #237 for re-adding the status bar icon. But don't expect this to some back unless there will be more requesting this, as it currently it is very low on my to long priority list.

Regarding the Favicon icon, are you sure you have enabled the option, and are viewing a mail of one of the supported domains for this (https://github.com/lieser/dkim_verifier/blob/master/data/favicon.json)? This should work in TB 78 too.

If not, please disable all other add-ons, restart TB and try again. Maybe there is an incompatibility with another add-on.

[lieser]

Attached is a test version for people affected by recently fixed bugs. The storing of DKIM keys is also migrated in this.
dkim_verifier-4.0.0pre4.1.zip

[Railander]

@Railander I created the separated issue #237 for re-adding the status bar icon. But don't expect this to some back unless there will be more requesting this, as it currently it is very low on my to long priority list.

Regarding the Favicon icon, are you sure you have enabled the option, and are viewing a mail of one of the supported domains for this (https://github.com/lieser/dkim_verifier/blob/master/data/favicon.json)? This should work in TB 78 too.

If not, please disable all other add-ons, restart TB and try again. Maybe there is an incompatibility with another add-on.

i understand the status bar might be more involving, i'd be fine even if the ball icon was readded in the "From:" header instead of color filtering the text or background.

regarding the favicon, it's always been enabled (just double-checked) and at some point it stopped showing. for example, our corporate domain uses g-suite and it did show the favicon back then but no longer does.

[lieser]

regarding the favicon, it's always been enabled (just double-checked) and at some point it stopped showing. for example, our corporate domain uses g-suite and it did show the favicon back then but no longer does.

Did you look if the signing domain appears in the list I linked to? Maybe the domain changed, at least i can't remember that I removed a google related domain from it.

To debug the problem, please:

• Look in Thunderbird's error console if there is an error shown
• Try it with different mails that should be in the list, e.g. GitHub notifications (note that you need to enable Still verify the signature, if a domain is only testing DKIM in advanced options), Amazon, PayPal
• Send me an affected mail as a saved eml file to [email protected]

[lieser]

@peci1 Note that your issue with only downloading the message headers (https://bugzilla.mozilla.org/show_bug.cgi?id=1659555) seems to be fixed in the latest daily. Don't know then it will be fixed in the normal release of Thunderbird.

[peci1]

@peci1 Note that your issue with only downloading the message headers (https://bugzilla.mozilla.org/show_bug.cgi?id=1659555) seems to be fixed in the latest daily. Don't know then it will be fixed in the normal release of Thunderbird.

Thanks for letting me know!

[lieser]

Good news, the conversion to an MailExtension is finally completed. I will still do some testing, and probably release the final 4.0.0 version next weekend. If you want to already try it out, attached is the current state.
Please report any issues you may still encounter.

dkim_verifier-4.0.0pre4.2.zip

[gene-git]

Great thank you Philippe - working fine so far in 78.9.1

[gene-git]

One comment - the DKIM button in the header row on right.

My theme is dark them - the button is in dark them but clicking it brings up white background with 4 buttons.
First button (revirfify) has black background with white text - it looks great.
The other 3 buttons have white text on light gray background (hard to read) and all 4 items sit on a white backrgound.

I'd say change the white bg which holds the 4 buttons to something from dark palette - like the rest of TB when in dark theme.
Add more contrast to the 3 grayed out buttons.

Best

gene

[lieser]

Thanks for reporting the issue with the dark theme. Just tried the one built into TB (on Windows), and although it looks bad and definitely needs improvements, it does not look like what you described. Will look into it next week.

Note that the difference in the buttons you descibe is probably from most of the buttons being disabled. They only get enabled if the action actually makes sense for the currently viewed mail and the configured options.

[gene-git]

kde plasma in dark theme. Yours looks worse lol ...
Understand only enabled when appropriate ... anyway this is what it looks like on my setup.

[gene-git]

Bigger issue to me is the white background.
The disabled text just needs a tad more contrast (more white less gray maybe).

[gene-git]

And these are really minor issues - the important stuff is the functionality and thats working great - thank you!

[lieser]

@gene-git The dark theme issue should be fixed. Can you please try out the attached version? Thanks.
dkim_verifier-4.0.0pre4.3.zip

[gene-git]

Yes - confirmed - it looks fine now - thank you!

[gene-git]

[lieser]

Took a lot longer than I initially hoped for, but with the release of version 4.0.0 I did just now the migration is finally over. On ATN it is still under review, and should show up in the next couple of days.

Thanks a lot to all of your for your patience, and reporting any bugs you found during the process.
If you find any new Problems, please create a separate issue instead of using this one.

[gene-git]

thank you ... :)