Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer events order #722

Merged

Conversation

krogla
Copy link
Member

@krogla krogla commented Apr 3, 2023

  • fix transfer events order (for subgraph)
  • check hasInitialized on resume
  • refactor bootstrap initial holder

@folkyatina
Copy link
Member

Looks good and even close the issue 5.2 from the old audit that we previously acknowledged.

One thing bothers me:

  • INITIAL_TOKEN_HOLDER defined in StETH, but used in Lido.
  • StETH is not actually usable without calling _bootstrapInitialHolder() but nothing in StETH tells you about it.

But I'm not sure what is the best thing to do here. Probably, adding explicit _mintInitialShares() or at least a comment will work.

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for delivering this

Pushed a bit of chore changes.
Left a few suggestions on the code structure itself.

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Show resolved Hide resolved
@TheDZhon TheDZhon merged commit e4f556c into fix/shapella-upgrade-from-rc0-to-rc1 Apr 4, 2023
@TheDZhon TheDZhon deleted the fix/transfer-events-order branch April 4, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants