Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: stake limit resume handling #721

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Fix: stake limit resume handling #721

merged 2 commits into from
Apr 2, 2023

Conversation

TheDZhon
Copy link
Contributor

folkyatina
folkyatina approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but can optionally use some work on naming and comments.
As for me, prevStakeLimit is really misleading name here and can use some rebranding.

contracts/0.4.24/lib/StakeLimitUtils.sol Outdated Show resolved Hide resolved
loga4
loga4 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@loga4 loga4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, all is good

@TheDZhon TheDZhon mentioned this pull request Mar 31, 2023
Merged
23 tasks
@TheDZhon
Copy link
Contributor Author

TheDZhon commented Apr 2, 2023

Fine, but can optionally use some work on naming and comments. As for me, prevStakeLimit is really misleading name here and can use some rebranding.

Agree, added a few comments, but decided to not proceed with a large-scale refactoring

@TheDZhon TheDZhon merged commit 7355d2e into fix/shapella-upgrade-from-rc0-to-rc1 Apr 2, 2023
@TheDZhon TheDZhon deleted the fix/stake-limit-after-pause branch April 2, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loga4 loga4 loga4 approved these changes

@folkyatina folkyatina folkyatina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheDZhon @folkyatina @loga4