Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statemind report minor fixes #720

Merged
merged 7 commits into from
Apr 2, 2023
Merged

Statemind report minor fixes #720

merged 7 commits into from
Apr 2, 2023
+150 −49

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Mar 30, 2023

No description provided.

@TheDZhon TheDZhon mentioned this pull request Mar 30, 2023
Merged
23 tasks
@Psirex Psirex marked this pull request as ready for review March 31, 2023 00:03
TheDZhon
TheDZhon approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks pretty reasonable and neat.
Only a single consideration regarding intrinsic limits for sanity checks

contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol Show resolved Hide resolved
@TheDZhon TheDZhon merged commit d2227cc into fix/shapella-upgrade-from-rc0-to-rc1 Apr 2, 2023
@TheDZhon TheDZhon deleted the fix/shapella-minor-statemind-findings branch April 2, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Psirex @TheDZhon