-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove int64 limitations #719
Merged
TheDZhon
merged 10 commits into
fix/shapella-upgrade-from-rc0-to-rc1
from
fix/nor-int64-math
Apr 4, 2023
Merged
fix: remove int64 limitations #719
TheDZhon
merged 10 commits into
fix/shapella-upgrade-from-rc0-to-rc1
from
fix/nor-int64-math
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psirex
reviewed
Mar 30, 2023
23 tasks
@Psirex please consider resolving the conflicts by integrating the changes from the upstream branch (have divergent changes of the lastly pushed commits) 🙏 |
TheDZhon
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Please consider addressing the minor outdated naming issue
…ofinance/lido-dao into fix/nor-int64-math
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
uint256
type instead ofuint64
inNodeOperatorsRegestry
to work with node operator validators' data. Validate that the resulting value doesn't exceed theUINT64_MAX
in thePacked64x4.set()
method.SafeMath
or asserts before/after calculationsNodeOperatorsRegistry contract size reduced from 23.971 to 23.169 KB
Gase changes for most often used methods based on unit tests
obtainDepositData()
onExitedAndStuckValidatorsCountsUpdated()
updateExitedValidatorsCount()