Fix (SignatureUtils): check the EIP-1271 call result more strictly #714
+71
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that 1) the returned data size is exactly 32 bytes; 2) only the first 4 bytes are non-zero; 3) these 4 bytes contain the magic value This doesn't support contracts right-padding the magic value with zeroes to a size longer than 32 bytes, like the Solidity ABI decoder allows, but that's a really exotic edge-case
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that:
This doesn't support contracts that right-pad the magic value with zeroes to a size longer than 32 bytes like the Solidity ABI decoder currently allows, but that's a really exotic edge case since it breaks the ABI specification for the
bytes4return data type.