Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make isLimitReached more coherent #710

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Fix: make isLimitReached more coherent #710

merged 2 commits into from
Apr 2, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Mar 28, 2023 •
edited
Loading

@TheDZhon TheDZhon mentioned this pull request Mar 28, 2023
Merged
23 tasks
folkyatina
folkyatina approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

loga4
loga4 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@loga4 loga4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Psirex
Psirex approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@Psirex Psirex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏻

contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
@TheDZhon TheDZhon merged commit e26094c into fix/shapella-upgrade-from-rc0-to-rc1 Apr 2, 2023
@TheDZhon TheDZhon deleted the fix/rebaseLimiter-isLimitReached branch April 2, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psirex Psirex Psirex approved these changes

@loga4 loga4 loga4 approved these changes

@folkyatina folkyatina folkyatina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheDZhon @folkyatina @loga4 @Psirex