Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional test cases #695

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Additional test cases #695

merged 6 commits into from
Mar 20, 2023

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Mar 19, 2023

PR adds the following tests:

  • unit tests for OssifiableProxy
  • scenario test for incomplete exited keys reporting

TheDZhon
TheDZhon reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for delivering this

Can't find one test helper 🕵️

test/0.4.24/lido-deposit-scenarios.test.js Show resolved Hide resolved
@TheDZhon TheDZhon mentioned this pull request Mar 20, 2023
Merged
15 tasks
TheDZhon
TheDZhon approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheDZhon TheDZhon merged commit 04ba9a8 into fix/shapella-upgrade-beta3-to-rc Mar 20, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade-additional-test-cases branch March 20, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Psirex @TheDZhon