Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy oracle Lido report tests #687

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Mar 15, 2023

Added test for report passthrough on AccountingOracle->Lido->LegacyOracle. Discovered interesting lastProcessedRefSlot behavior in case of legacy oracle migration.

@TheDZhon TheDZhon changed the base branch from feature/shapella-upgrade to fix/shapella-upgrade-beta3-to-rc March 16, 2023 07:35
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Please consider addressing the proposed changes.

test/0.4.24/legacy-oracle.test.js Show resolved Hide resolved
@Jeday Jeday requested a review from TheDZhon March 17, 2023 08:17
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚅

@TheDZhon TheDZhon merged commit d8703d4 into fix/shapella-upgrade-beta3-to-rc Mar 20, 2023
@TheDZhon TheDZhon deleted the feature/legacy-oracle-lido-report-tests branch March 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants