NFTDescriptor for WithdrawalQueueERC721 #646
Merged
+41
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NFT for WithdrawalQueueERC721✨
folkyatina
approved these changes
Feb 21, 2023
| import {UnstructuredStorage} from "./lib/UnstructuredStorage.sol"; | ||
|
|
||
| /** | ||
| * @title Interface defining INFTDescriptor to generate ERC721 metadata |
There was a problem hiding this comment.
Nitpicking alert. Actually it provides only tokenURI, because ERC721 metadata includes name and symbol as well.
| @@ -90,11 +105,18 @@ contract WithdrawalQueueERC721 is IERC721Metadata, WithdrawalQueue { | |||
| } | |||
|
|
|||
| /// @dev See {IERC721Metadata-tokenURI}. | |||
| /// @dev If NFTDescriptor address isn't set the `baseURI` would be used for generating erc721 metadata. In case | |||
| /// NFTDescriptor address is set it would be used as a priority method. | |||
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add NFTDescriptor as an on-chain way of generating metadata for WithdrawalQueueERC721