Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add OracleDaemonConfig to LidoLocator #630

Merged
merged 5 commits into from
Feb 18, 2023
Merged

Fix: add OracleDaemonConfig to LidoLocator #630

merged 5 commits into from
Feb 18, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Feb 17, 2023 •
edited
Loading

Add a dedicated getter method for the OracleDaemonConfig contract.

  • Implement the contract
  • Update interface
  • Check that tests are not broken
  • Update tests for the contract itself

@TheDZhon TheDZhon changed the title fix: add OracleDaemonConfig to LidoLocator Fix: add OracleDaemonConfig to LidoLocator Feb 17, 2023
@TheDZhon TheDZhon mentioned this pull request Feb 18, 2023
Merged
26 tasks
@TheDZhon TheDZhon marked this pull request as ready for review February 18, 2023 19:34
arwer13
arwer13 approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@arwer13 arwer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TheDZhon TheDZhon merged commit 9867298 into feature/shapella-upgrade-followups Feb 18, 2023
@TheDZhon TheDZhon deleted the fix/oracle-daemon-config-locator branch February 18, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arwer13 arwer13 arwer13 approved these changes

@bulbozaur bulbozaur Awaiting requested review from bulbozaur

@avsetsin avsetsin Awaiting requested review from avsetsin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDZhon @arwer13