Accounting oracle: tests & fixes #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DiRaiks
commented
Feb 14, 2023
•
DiRaiks
commented
- access control
- initialize pre-conditions
- legacy oracle migration
- submitReportData checks contract version
- submitReportData checks ref. slot
- submitReportData checks data hash
- submitReportData checks consensus version
- submitReportData delivers the data to Lido and StakingRouter
- submitReportData enforces extra data format
- submitReportData enforces zero extra data items count for the empty format
- submitReportData enforces zero data hash for the empty format
- submitReportData enforces non-zero extra data items count for any format apart from empty
- submitReportData enforces module ids sorting order
- submitReportData enforces data safety boundaries
- submitReportData resets and populates extra data processing state
- submitReportExtraDataList enforces the deadline
- submitReportExtraDataList checks extra data hash
- submitReportExtraDataList checks ref slot
- submitReportExtraDataList reverts if extra data already processed
- (!!!) submitReportExtraDataList reverts if extra data partially processed [not reachable with current contract]
- submitReportExtraDataList reverts if main data for the ref. slot not yet submitted
- submitReportExtraDataList checks items count
- submitReportExtraDataList enforces data format
- submitReportExtraDataList enforces data sorting order
- submitReportExtraDataList enforces data safety boundaries
- submitReportExtraDataList delivers the data to staking router
- submitReportExtraDataList updates extra data processing state
- submitReportExtraDataList handles edge cases regarding the data
- events (as part of other tests)
- No check for report in submitReportData #634
26 tasks
… 'feature/shapella-upgrade-tests-accounting-oracle' of github.com:lidofinance/lido-dao into feature/shapella-upgrade-tests-accounting-oracle
…gOracle._processExtraDataItems
…thub.com:lidofinance/lido-dao into feature/shapella-upgrade-tests-accounting-oracle
skozin
approved these changes
Feb 18, 2023
skozin
force-pushed
the
feature/shapella-upgrade-tests-accounting-oracle
branch
from
ef0cc67
to
3f65232
Compare
skozin
force-pushed
the
feature/shapella-upgrade-tests-accounting-oracle
branch
from
3f65232
to
113fb29
Compare
TheDZhon
reviewed
Feb 19, 2023
skozin
force-pushed
the
feature/shapella-upgrade-tests-accounting-oracle
branch
from
42ddff5
to
fece521
Compare
TheDZhon
changed the base branch from
feature/shapella-upgrade
to
feature/shapella-upgrade-followups
…la-upgrade-tests-accounting-oracle
TheDZhon
deleted the
feature/shapella-upgrade-tests-accounting-oracle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.