Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batching view methods for StakingRouter #606

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Feb 13, 2023

The main changes in the PR:

  • add method getStakingModuleSummary(uint256 _stakingModuleId) into the StakingRouter to retrieve the validator's summary about the staking module in the form of struct StakingModuleSummary.

  • add method getNodeOperatorSummary(uint256 _stakingModuleId, uint256 _nodeOperatorId) into the StakingRouter to retrieve the node operator's summary in the form of struct NodeOperatorSummary

  • replace StakingModuleReport and NodeOperatorReport with StakingModuleDigest and NodeOperatorDigest accordingly. Here and below, the "digest" used in the meaning of "the compilation of main data"

  • rename getAllStakingModuleReports(), getStakingModuleReports(), getAllNodeOperatorReports(), and getNodeOperatorReports() into getAllStakingModuleDigests(), getStakingModuleDigests(), getAllNodeOperatorDigests(), and getNodeOperatorDigests() accordingly.

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it merged 👍

@TheDZhon TheDZhon merged commit 52ae638 into feature/post-zhejiang-fixes Feb 13, 2023
@TheDZhon TheDZhon deleted the feature/staking-router-batch-methods-update branch February 13, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants