-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: move sanity check out of while loop for optimizing gas usage #604
Merged
TheDZhon
merged 2 commits into
feature/post-zhejiang-fixes
from
refactor/gas-golfing-for-accounting-oracle-check
Feb 13, 2023
Merged
Refactor: move sanity check out of while loop for optimizing gas usage #604
TheDZhon
merged 2 commits into
feature/post-zhejiang-fixes
from
refactor/gas-golfing-for-accounting-oracle-check
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujenjt
changed the title
refactor: move sanity check out of while loop for optimizing gas usage
Refactor: move sanity check out of while loop for optimizing gas usage
Feb 12, 2023
TheDZhon
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TheDZhon
changed the base branch from
feature/shapella-upgrade
to
feature/post-zhejiang-fixes
February 13, 2023 06:40
arwer13
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
folkyatina
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. LGTM
skozin
reviewed
Feb 13, 2023
skozin
reviewed
Feb 13, 2023
skozin
approved these changes
Feb 13, 2023
TheDZhon
deleted the
refactor/gas-golfing-for-accounting-oracle-check
branch
February 13, 2023 16:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move sanity check out of while loop for optimizing gas usage