Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move sanity check out of while loop for optimizing gas usage #604

Conversation

ujenjt
Copy link
Member

@ujenjt ujenjt commented Feb 12, 2023

Move sanity check out of while loop for optimizing gas usage

photo_2023-02-12 20 26 47

@ujenjt ujenjt changed the title refactor: move sanity check out of while loop for optimizing gas usage Refactor: move sanity check out of while loop for optimizing gas usage Feb 12, 2023
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon TheDZhon changed the base branch from feature/shapella-upgrade to feature/post-zhejiang-fixes February 13, 2023 06:40
Copy link
Contributor

@arwer13 arwer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. LGTM

contracts/0.8.9/oracle/AccountingOracle.sol Outdated Show resolved Hide resolved
@TheDZhon TheDZhon merged commit 9cfe6b9 into feature/post-zhejiang-fixes Feb 13, 2023
@TheDZhon TheDZhon deleted the refactor/gas-golfing-for-accounting-oracle-check branch February 13, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants