Another set of minor improvements #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDZhon
reviewed
Feb 10, 2023
contracts/0.8.9/WithdrawalQueue.sol
Outdated
|
|
||
| bool isBunkerModeWasSetBefore = isBunkerModeActive(); | ||
|
|
||
| // on bunker mode state change | ||
| if (_isBunkerModeNow != isBunkerModeWasSetBefore) { | ||
| // write previous timestamp to enable bunker or max uint to disable | ||
| uint256 newTimestamp = _isBunkerModeNow ? _bunkerModeSinceTimestamp : BUNKER_MODE_DISABLED_TIMESTAMP; | ||
| uint256 newTimestamp = _isBunkerModeNow ? _sinceTimestamp : BUNKER_MODE_DISABLED_TIMESTAMP; |
TheDZhon
reviewed
Feb 10, 2023
| @@ -59,7 +59,8 @@ abstract contract WithdrawalQueueBase { | |||
| /// @notice structure to store discount factors for requests in the queue | |||
| struct DiscountCheckpoint { | |||
| /// @notice first `_requestId` the discount is valid for | |||
| uint256 fromRequestId; | |||
| /// @dev storing in uint160 to pack into one slot. Overflowing here is unlikely | |||
| uint160 fromRequestId; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.