Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base oracle: tests and fixes (shapella upgrade) #590

Merged
merged 26 commits into from
Feb 13, 2023
Merged

Base oracle: tests and fixes (shapella upgrade) #590

merged 26 commits into from
Feb 13, 2023

Conversation

DiRaiks
Copy link
Contributor

@DiRaiks DiRaiks commented Feb 10, 2023 •
edited
Loading

tests Base Oracle

  • access control
  • setting consensus contract
  • setting consensus version
  • submitReport pre-conditions
  • submitReport => getConsensusReport
  • submitReport calls _handleConsensusReport
  • _setConsensusContract pre-conditions
  • _startProcessing pre-conditions
  • _startProcessing advances last processing ref slot
  • _checkConsensusData
  • events (as part of other tests)

@DiRaiks DiRaiks marked this pull request as draft February 10, 2023 07:31
Jeday and others added 24 commits February 11, 2023 18:06
@Jeday
feat: submitReport => getConsensusReport tests, helpers linting
cae279f
@Jeday
fix: handle report resubmit case
2bece61
@Jeday
fix: missing await in assertRevert
82d768a
@DiRaiks
Merge branch 'feature/shapella-upgrade' of github.com:lidofinance/lid…
5eb1d9f 
…o-dao into feature/shapella-upgrade-tests-base-oracle
@Jeday
feat: set consensus contract,version tests and helper contract updates
3618050
@DiRaiks
test: base oracle: add access control tests, add admin to deploy
d348148
@DiRaiks
Merge branch 'feature/shapella-upgrade-tests-base-oracle' of github.c…
77276e0 
…om:lidofinance/lido-dao into feature/shapella-upgrade-tests-base-oracle
@DiRaiks
test: base oracle: change mock init
81ea055
@Jeday
feat: checkConsensusData tests & relevant mock updates
c8bbc7c
@manneredboor
fix: helper utils imports typo error
fe0b5bf
@manneredboor
test: method getReportVariants returns empty data if lastReportRefSlo…
f773d36 
…t != currentFrame.refSlot
@manneredboor
test: HashConsensus deploy reverts if admin or processor address equa…
e774e5c 
…ls zero
@manneredboor
test: addMember reverts if member address equals zero
94b6cd0
@manneredboor
test: refactor helpers usage
39a4e6e
@manneredboor
test: HashConsensus.setFastLaneLengthSlots
a426b57
@DiRaiks
test: base oracle: fix test disc
830f07f
@manneredboor
test: HashConsensus Report Submitting revert cases
de17bb0
@manneredboor
test: fix fast lane length naming
2ec33f9
@Jeday
feat: startProcessing tests & update helper
bfc7d74
@Jeday
Merge branch 'feature/shapella-upgrade-tests-base-oracle' of github.c…
71a955e 
…om:lidofinance/lido-dao into feature/shapella-upgrade-tests-base-oracle
@Jeday
fix: clean up helpers
d547911
@skozin
Merge pull request #601 from lidofinance/fix/repeating-missed-report-…
cda3398 
…event

fix: handle report resubmit case
@Jeday
feat: added missing functions tests
68d7fe4
@Jeday
chore: clean up, formatting, typos
87c3398
@Jeday Jeday changed the title WIP: Feature/shapella upgrade tests base oracle Feature/shapella upgrade tests base oracle Feb 12, 2023
@Jeday Jeday marked this pull request as ready for review February 12, 2023 13:59
@skozin skozin changed the title Feature/shapella upgrade tests base oracle Base oracle: tests and fixes (shapella upgrade) Feb 13, 2023
@TheDZhon TheDZhon changed the base branch from feature/shapella-upgrade to feature/post-zhejiang-fixes February 13, 2023 16:00
TheDZhon
TheDZhon approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TheDZhon TheDZhon merged commit c7bd2f7 into feature/post-zhejiang-fixes Feb 13, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade-tests-base-oracle branch February 13, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkyatina folkyatina folkyatina left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

@skozin skozin Awaiting requested review from skozin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DiRaiks @TheDZhon @folkyatina @Jeday @manneredboor @skozin