Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeOperatorRegistry limits features v2 #557

Merged
merged 46 commits into from
Feb 10, 2023
Merged

NodeOperatorRegistry limits features v2 #557

merged 46 commits into from
Feb 10, 2023

Conversation

loga4
Copy link
Contributor

@loga4 loga4 commented Feb 6, 2023 •
edited
Loading

  • added stuck/stuck time/forgiven counters
  • added target limit
  • added invalidateReadyToDepositKeysRange(uint256 _indexFrom, uint256 _indexTo)
  • reduce roles
  • rewrite key management

codesize: 24.521

krogla and others added 23 commits February 5, 2023 19:26
@TheDZhon TheDZhon mentioned this pull request Feb 7, 2023
Merged
@krogla krogla changed the title Add NodeOperatorRegistry limits features v2 NodeOperatorRegistry limits features v2 Feb 7, 2023
ujenjt
ujenjt reviewed Feb 9, 2023
View reviewed changes
contracts/0.4.24/nos/NodeOperatorsRegistry.sol
// bytes32 public constant ACTIVATE_NODE_OPERATOR_ROLE = keccak256("MANAGE_NODE_OPERATOR_ROLE");
bytes32 public constant MANAGE_NODE_OPERATOR_ROLE = 0x78523850fdd761612f46e844cf5a16bda6b3151d6ae961fd7e8e7b92bfbca7f8;
// bytes32 public constant STAKING_ROUTER_ROLE = keccak256("STAKING_ROUTER_ROLE");
bytes32 public constant STAKING_ROUTER_ROLE = 0xbb75b874360e0bfd87f964eadd8276d8efb7c942134fc329b513032d0803e0c6;

//
// CONSTANTS
//
uint256 public constant MAX_NODE_OPERATORS_COUNT = 200;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is safe limit now? still 200?

@TheDZhon TheDZhon merged commit ef1d303 into feature/shapella-upgrade Feb 10, 2023
@TheDZhon TheDZhon deleted the feature/nor-limits branch February 10, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krogla krogla krogla left review comments

@ujenjt ujenjt ujenjt left review comments

@TheDZhon TheDZhon TheDZhon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loga4 @TheDZhon @ujenjt @krogla