Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ValidatorExitBusOracle pausable #553

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

arwer13
Copy link
Contributor

@arwer13 arwer13 commented Feb 5, 2023

  • only submitReportData forbidden when paused (hash consensus not affected)
  • create base utility contract PausableUntil
  • inherit WithdrawalQueue from PausableUntil

- only `submitReportData` forbidden when paused (hash consensus not affected)
- create base utility contract PausableUntil
- inherit it in WithdrawalQueue as well
@TheDZhon
Copy link
Contributor

TheDZhon commented Feb 6, 2023

Thank you for shipping this blazingly fast 👍
Could you possibly resolve the conflicts?

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clean and concise 👍

@arwer13 arwer13 merged commit c7c4d46 into feature/shapella-upgrade Feb 6, 2023
@arwer13 arwer13 deleted the pausable-exit-bus-oracle branch February 6, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants