Feat: LidoLocator behind Proxy #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TheDZhon
requested changes
Feb 3, 2023
skozin
reviewed
Feb 3, 2023
TheDZhon
approved these changes
Feb 3, 2023
|
|
||
| // See contracts/COMPILERS.md | ||
| // solhint-disable-next-line | ||
| pragma solidity 0.4.24||0.8.9; |
TheDZhon
reviewed
Feb 3, 2023
| function withdrawalQueue() external view returns(address); | ||
| function withdrawalVault() external view returns(address); | ||
| function coreComponents() external view returns( | ||
| address, |
There was a problem hiding this comment.
we can document return var names in the interface file I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new contract: Proxied LidoLocator. All addresses are immutable to avoid storage-read operations for gas efficiency. Whenever Locator needs changing, simply upgrade the implementation.