Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use unstructured AccessControl everywhere #519

Merged
merged 1 commit into from
Jan 31, 2023
Merged

feat: use unstructured AccessControl everywhere #519

merged 1 commit into from
Jan 31, 2023
+10 −17

Conversation

folkyatina
Copy link
Member

No description provided.

TheDZhon
TheDZhon approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's totally cool.
@skozin said that he is going to integrate this approach for oracle also.

contracts/0.8.9/WithdrawalQueue.sol
///! SLOT 6: uint256 lastDiscountIndex
///! SLOT 7: uint128 public lockedEtherAmount
///! SLOT 8: mapping(address => uint256[]) requestsByRecipient
///! SLOT 0: mapping(uint256 => WithdrawalRequest) queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
The endgame is to have unstructured contract I suppose (like StakingRouter)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. But I will do it in another PR later.

@folkyatina folkyatina merged commit 9a96aeb into feature/shapella-upgrade Jan 31, 2023
@folkyatina folkyatina deleted the feature/unstructured_access_control branch January 31, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkyatina @TheDZhon