Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: positive rebase limiter #514

Merged
merged 19 commits into from
Feb 2, 2023

Conversation

TheDZhon
Copy link
Contributor

fixes #428

@TheDZhon TheDZhon linked an issue Jan 30, 2023 that may be closed by this pull request
@TheDZhon TheDZhon changed the base branch from feature/shapella-upgrade to feature/wq_review_fixes January 30, 2023 12:11
Base automatically changed from feature/wq_review_fixes to feature/shapella-upgrade January 30, 2023 12:14
@TheDZhon TheDZhon marked this pull request as ready for review January 31, 2023 12:16
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through briefly. Will do another round later

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/lib/PositiveTokenRebaseLimiter.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Show resolved Hide resolved
@TheDZhon
Copy link
Contributor Author

TheDZhon commented Feb 1, 2023

Ok, thank you, folks!
Pushed another update 🎸

@TheDZhon TheDZhon requested a review from arwer13 February 1, 2023 16:55
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little marks

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
@folkyatina folkyatina merged commit d5bd1c2 into feature/shapella-upgrade Feb 2, 2023
@folkyatina folkyatina deleted the feature/rebase-limiter branch February 2, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single stETH rebasing limit
4 participants