Feat/use only id externally #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mymphe
changed the base branch from
feature/shapella-upgrade
to
fix/typos-base-precision
arwer13
force-pushed
the
fix/typos-base-precision
branch
from
582f7ef
to
36112d1
Compare
Base automatically changed from
fix/typos-base-precision
to
feature/shapella-upgrade
January 28, 2023 11:42
skozin
reviewed
Jan 29, 2023
contracts/0.4.24/Lido.sol
Outdated
| ); | ||
| (_getTotalPooledEther().mul(precisionPoints)) | ||
| .sub(_totalRewards.mul(totalFee)) | ||
| ); |
There was a problem hiding this comment.
Why this formatting change? The result is much less readable.
There was a problem hiding this comment.
That change pertains to a former base branch, fix/typos-base-precision which has already been merged to #482. This PR includes change only to StakingRouter and respective tests.
…ance/lido-dao into feat/use-only-id-externally
|
Could you please update the PR to resolve conflicts? |
…ance/lido-dao into feat/use-only-id-externally
Conflicts resolved. |
krogla
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides staking module indexes from the external interface. All external setters and getters use module ids now. Additionally, StakingRouter provides a getter for all module ids.