Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle upgrade #495

Merged
merged 52 commits into from
Jan 30, 2023
Merged

Oracle upgrade #495

merged 52 commits into from
Jan 30, 2023
+5,976 −308

Conversation

skozin
Copy link
Member

@skozin skozin commented Jan 17, 2023 •
edited
Loading

Oracle complete re-write:

  • Oracle members agree on the data hash instead of the data itself; the data is submitted in a separate tx.
  • Pass more data required for withdrawals.
  • Introduce a second oracle, the validator exit bus.

@skozin skozin changed the base branch from master to feature/shapella-upgrade January 17, 2023 13:04
@skozin skozin marked this pull request as draft January 18, 2023 10:38
@skozin skozin force-pushed the feature/oracle-upgrade branch 2 times, most recently from f60b3f7 to 060f006 Compare January 20, 2023 18:17
skozin
skozin commented Jan 26, 2023
View reviewed changes
contracts/0.8.9/StakingRouter.sol
}
}

function updateExitedKeysCountByStakingModule(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add a handle that allows the DAO to forcibly decrease exited keys count for staking module and its operators so that it's possible to correct an oracle error manually.

@skozin skozin force-pushed the feature/oracle-upgrade branch 2 times, most recently from 155d5d3 to 01cc0e9 Compare January 28, 2023 23:18
@skozin skozin changed the title Oracle upgrade (WIP) Oracle upgrade Jan 29, 2023
@skozin skozin marked this pull request as ready for review January 29, 2023 02:15
@skozin
fix test context name
f4546c1
@skozin
oracle: declare interfaces in the files using them
c144794
@skozin
oracle: naming, docs, and consistency improvements
7689d69
@skozin
oracle: more consistent code layout across files
48e3376
@skozin
oracle: use a modified version of OZ AccessControl employing unstruct…
41a9764 
…ured storage
@skozin
Merge remote-tracking branch origin/feature/shapella-upgrade into fea…
fafd6af 
…ture/oracle-upgrade
@skozin
staking router: fix loading modules into cache
0582051
@skozin
lido: optimize contract size by not using public when it's not needed
c9840f1
@skozin
lido: remove funds recovery support to save contract size
895d658
@skozin
lido: remove getFee fn as this can be obtained via getFeeDistribution
71af67b
@skozin
move getFeeDistribution from lido to router
c66f686
@skozin
lido: misc contract size optimizations
7e8cb0d
@skozin
oracle: add forgotten visibility specificators
0d2bb32
@skozin
oracle: use the custom version of access control lib even when unstr.…
0e54462 
… storage is not required
@skozin skozin merged commit 594f8c0 into feature/shapella-upgrade Jan 30, 2023
@skozin skozin deleted the feature/oracle-upgrade branch January 30, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsetsin avsetsin avsetsin left review comments

@TheDZhon TheDZhon TheDZhon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skozin @TheDZhon @avsetsin