feat: add AccessControl to managing ACL in WQ #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arwer13
requested changes
Jan 12, 2023
TheDZhon
approved these changes
Jan 12, 2023
| bytes32 internal constant REQUESTS_PLACEMENT_RESUMED_POSITION = | ||
| keccak256("lido.WithdrawalQueue.requestsPlacementResumed"); | ||
| /// Withdrawal queue resume/pause control storage slot | ||
| bytes32 internal constant RESUMED_POSITION = keccak256("lido.WithdrawalQueue.resumed"); | ||
|
|
||
| /// Lido stETH token address to be set upon construction | ||
| address public immutable STETH; |
There was a problem hiding this comment.
Should be placed in unstructured storage eventually
There was a problem hiding this comment.
Should it? Not sure that it can be changed in a some way.
Base automatically changed from
feature/withdrawal_tests
to
feature/shapella-upgrade
January 13, 2023 10:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add role-based access control to WithdrawalQueue
There are three roles:
and pause now is for finalization also