-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LidoOracleNew, ValidatorExitBus: initial rough version of hash consensus #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Blazingly fast
Though, have some questions 👀 :
Current gas consumption of
and without
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for our needs.
There is some places that can be rewritten for clarity , but it is not worth it since we'll rewrite it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good enough for testnets 👍
Initial untidy version of hash consensus, with further data report in single tx. Its purpose is to provide tooling with capability to test agains "two-phaseness".
It will be reimplemented/updated by further solid PR.
NB: gas consumption of reporting keys to eject (call to
ValidatorExitBus.handleReportData
) is:(see test "Calculate gas usages")