Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring Withdrawal tests #484

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Restoring Withdrawal tests #484

merged 8 commits into from
Jan 13, 2023

Conversation

folkyatina
Copy link
Member

@folkyatina folkyatina commented Jan 10, 2023 •
edited
Loading

  • restore basic Withdrawal queue tests
  • fix a bug sneaked from WQv0 on request creation
  • fix a bug with shares precision calculation on finalization
  • unify assertReverts for custom error solutions

@folkyatina folkyatina marked this pull request as ready for review January 12, 2023 12:33
TheDZhon
TheDZhon requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have some questions and concerns 👀

contracts/0.8.9/WithdrawalQueue.sol Show resolved Hide resolved
contracts/0.8.9/WithdrawalQueue.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalQueue.sol Show resolved Hide resolved
test/0.8.9/withdrawal-queue.test.js Show resolved Hide resolved
test/0.8.9/withdrawal-queue.test.js Show resolved Hide resolved
test/helpers/assert.js Outdated Show resolved Hide resolved
test/helpers/utils.js Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

contracts/0.8.9/WithdrawalQueue.sol Show resolved Hide resolved
@folkyatina folkyatina merged commit 5680024 into feature/shapella-upgrade Jan 13, 2023
@folkyatina folkyatina deleted the feature/withdrawal_tests branch January 13, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loga4 loga4 loga4 left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

@arwer13 arwer13 Awaiting requested review from arwer13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folkyatina @TheDZhon @loga4