Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _OOP_find_proc_info #187

Closed
wants to merge 1 commit into from
Closed

Add _OOP_find_proc_info #187

wants to merge 1 commit into from

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Jun 11, 2020

This code was added to CoreCLR as part of dotnet/coreclr#26082. I am submitting the code exactly as it was committed in dotnet/coreclr#26082. We are open to refactoring to make this fit the libunwind design.

The code was written to avoid having to reimplement libunwind's dwarf parser so that we could implement out of process unwind for arm. It also allowed us to remove dwarf parse code for other architectures.

The PR is not necessarily complete. For instance this prototype should be made available in some header.

int
_OOP_find_proc_info(
    unw_word_t start_ip,
    unw_word_t end_ip,
    unw_word_t eh_frame_table,
    unw_word_t eh_frame_table_len,
    unw_word_t exidx_frame_table,
    unw_word_t exidx_frame_table_len,
    unw_addr_space_t as,
    unw_word_t ip,
    unw_proc_info_t *pi,
    int need_unwind_info,
    void *arg);

/cc @mikem8361 @djwatson

Comment on lines +1 to +3
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use the libunwind header.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Yea if possible change to libunwind header.

@am11
Copy link
Contributor

am11 commented Jun 11, 2020

Can it be exercised with a test in this repo?

@sdmaclea
Copy link
Contributor Author

I'll take a look at writing a test.

@djwatson
Copy link
Member

I'm not opposed to this, but at a minimum should be part of the build and have a test.

If you think it should be a public function, should probably have some documentation too, although I'm okay letting it be undocumented.

@sdmaclea sdmaclea marked this pull request as draft June 18, 2020 20:52
@sdmaclea
Copy link
Contributor Author

Sure. I'll clean this up next week.
I just finished integrating Windows libunwind into .NET Core master. It seems to be working.

@djwatson
Copy link
Member

djwatson commented Aug 4, 2020

Closing for now, feel free to reopen with tests & build additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants