-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _OOP_find_proc_info #187
Conversation
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use the libunwind header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Yea if possible change to libunwind header.
Can it be exercised with a test in this repo? |
I'll take a look at writing a test. |
I'm not opposed to this, but at a minimum should be part of the build and have a test. If you think it should be a public function, should probably have some documentation too, although I'm okay letting it be undocumented. |
Sure. I'll clean this up next week. |
Closing for now, feel free to reopen with tests & build additions. |
This code was added to CoreCLR as part of dotnet/coreclr#26082. I am submitting the code exactly as it was committed in dotnet/coreclr#26082. We are open to refactoring to make this fit the libunwind design.
The code was written to avoid having to reimplement libunwind's dwarf parser so that we could implement out of process unwind for arm. It also allowed us to remove dwarf parse code for other architectures.
The PR is not necessarily complete. For instance this prototype should be made available in some header.
/cc @mikem8361 @djwatson