Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differing implementation of gossipsub that handles errors and uses hashes of messages and topics instead of IDs #142

Closed
jamesray1 opened this issue Feb 7, 2019 · 1 comment

Comments

@jamesray1
Copy link
Contributor

jamesray1 commented Feb 7, 2019

This is a partial implementation of gossipsub that differs to the spec by handling errors and using hashes of messages and topics instead of IDs. While it is possible to use an enum containing either a hash or an ID, after trying to implement that I stopped due to additonal complexities around doing so, while there does not seem to be any advantage to using an ID over a hash.

Handled errors include when a topic is not in the mesh, and the local peer is not connected to the remote peer.
Relevant lines in the spec include:

Related: #130, #116

@raulk
Copy link
Member

raulk commented Mar 13, 2019

Thanks for the info, but this is not actionable. Implementors are welcome to submit RFCs to evolve the spec when they find areas for improvement.

@raulk raulk closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants