Skip to content

Conversation

@a1300
Copy link
Contributor

@a1300 a1300 commented Nov 26, 2020

I didn't changed the use of new Libp2p() in the examples/delegated-routing directory because this is already in progress in PR #507

return new Libp2p({
peerInfo,
peerBook,
// Lets limit the connection managers peers and have it check peer health less frequently
connectionManager: {
maxPeers: 10,
pollInterval: 5000
},

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Except for my two comments in the API doc, everything looks good

@a1300 a1300 requested a review from vasco-santos November 27, 2020 12:18
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos vasco-santos merged commit 7320495 into libp2p:master Nov 30, 2020
@a1300 a1300 deleted the docs_libp2p_create_example branch November 30, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants