Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit pings #32

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Limit pings #32

merged 1 commit into from
Aug 6, 2020

Conversation

Stebalien
Copy link
Member

  1. Only allow one outgoing ping at a time. There's no reason to send more than one.
  2. When responding to pings, write responses into a buffered ping response channel instead of spawning a goroutine per ping. Allow up to 32 response pings (instead of just one) to allow for old peers and timeouts.

@Stebalien
Limit pings
203f9c9 
1. Only allow one outgoing ping at a time. There's no reason to send more than one.
2. When responding to pings, write responses into a buffered ping response
channel instead of spawning a goroutine per ping. Allow up to 32 response
pings (instead of just one) to allow for old peers and timeouts.
@Stebalien Stebalien merged commit 0135c85 into master Aug 6, 2020
@Stebalien Stebalien deleted the feat/limit-pings branch August 6, 2020 00:53
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @whyrusleeping