Clearing inflight along with streams to avoid memory leak #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jun 23, 2020
| @@ -690,6 +690,7 @@ func (s *Session) incomingStream(id uint32) error { | |||
| // Backlog exceeded! RST the stream | |||
| s.logger.Printf("[WARN] yamux: backlog exceeded, forcing connection reset") | |||
| delete(s.streams, id) | |||
| delete(s.inflight, id) | |||
There was a problem hiding this comment.
This shouldn't be necessary, but it can't hurt.
| @@ -708,6 +709,7 @@ func (s *Session) closeStream(id uint32) { | |||
| } | |||
| } | |||
| delete(s.streams, id) | |||
| delete(s.inflight, id) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across a memory leak issue during a loadtest. Session.inflight was taking around 150MB of space in memory and it was never cleaned up.
We forked the repo and fixed it by clearing inflight along with the streams. We've tested it under load as well.
I'd be happy to help to get the PR merged. Let me know if you need anything from me,
This fixes #29