-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
very large number of "protocol mux failed: connection reset" errors #339
Comments
cc @bigs @Stebalien |
Could be TCP port scans (if this is happening when negotiating secio). |
@Stebalien mind elaborating a bit? |
That is:
Alternatively, this could be evil ISPs resetting our connections when we open too many (Comcast did this for a while in an attempt to break bittorrent). |
@Stebalien but i'm seeing these without a listener. I'm only dialing outwards. |
also see notes on: libp2p/go-libp2p-kad-dht#139 (comment) |
"connection reset" is coming from yamux. It really means that the stream was reset, not the connection. Thanks yamux. |
Where does the "protocol mux failed" come from? |
Ah... Lazy negotiation. |
Ah, no, I know exactly where this is coming from. A peer is trying to connect via a protocol you don't speak (probably bitswap). After you refuse to speak any of the requested protocols, the peer (correctly) hangs up with a reset. We should ignore these. |
Actually, should we be nice on encountering an unsupported protocol? We could nicely close the connection but that takes more time. |
No, we can't do that. I think we previously had a bug caused by that, where we would open a stream and start writing to it, and since the other side didnt support the protocol and only closed it, we never found out, and just kept writing into the void. |
Overall, I think this error i'm seeing here isnt really a problem. Just took a little while to figure out what it actually meant |
I'm going to at least improve the error message. |
do it. You can change the world. |
I'm playing around with debugging connectivity issues, and i'm seeing a lot of these errors coming out of basichost. It could be normal, but it definitely seems a bit odd. I'm opening this issue to track finding the cause and determining whether or not this is a deeper issue.
The text was updated successfully, but these errors were encountered: