Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: private/browser-to-private/server #2009

Open
6 tasks
Tracked by #475
p-shahi opened this issue Jan 23, 2023 · 8 comments · May be fixed by #2576
Open
6 tasks
Tracked by #475

webrtc: private/browser-to-private/server #2009

p-shahi opened this issue Jan 23, 2023 · 8 comments · May be fixed by #2576
Assignees

Comments

@p-shahi
Copy link
Member

p-shahi commented Jan 23, 2023

eta: 2023-09-30

This is the browser side implementation in go-libp2p (a scenario where the go-libp2p node is in a private network e.g. behind a NAT/firewall). It is required for a browser node to hole punch to a private non-browser node and will “complete” the browser connectivity story.

Done Criteria

@p-shahi p-shahi added this to the M3. WebRTC private_browser-to-private_server milestone Jan 23, 2023
@p-shahi
Copy link
Member Author

p-shahi commented Mar 7, 2023

Status update: @ckousik will start on this feature now, as most of the work on js-libp2p-webrtc browser-to-browser is complete (minus the potential multiaddr name change)
@ckousik @ddimaria please use this ticket to capture the work-plan/todos

@p-shahi p-shahi linked a pull request Mar 8, 2023 that will close this issue
@ddimaria
Copy link

@p-shahi p-shahi removed this from the M3. WebRTC private_browser-to-private_server milestone Jun 28, 2023
@sukunrt sukunrt self-assigned this Sep 19, 2023
@sukunrt sukunrt linked a pull request Sep 20, 2023 that will close this issue
@p-shahi p-shahi linked a pull request Sep 20, 2023 that will close this issue
@sukunrt sukunrt mentioned this issue Oct 27, 2023
19 tasks
@Jorropo
Copy link
Contributor

Jorropo commented Nov 22, 2023

What's gonna be our strategy for finding STUN servers ?
Hard-code some well known servers ? (bad, not local first)

Given STUN is cheap and can be easily rate limited I would argue public go-libp2p servers should include a STUN server, similar to how autonat and relay v2 is implemented right now, then in Kubo I can do the same thing I do for relay v2 where I select nodes based on the DHT keyspace.
I remember discussing this with @mxinden and there were concern than IPFS would unwillingly become public STUN service for all kind of unrelated spammy usecases.

@mxinden
Copy link
Member

mxinden commented Nov 22, 2023

Hard-code some well known servers ? (bad, not local first)

I don't have a good solution here. I would start with this, i.e. I would start with a hard-coded set of servers. Though products would need to make it explicit to the user that they are using the services of company X.

@omar391
Copy link

omar391 commented May 20, 2024

Bump: I can see many open PRs. Any update on this?

@sukunrt
Copy link
Member

sukunrt commented May 20, 2024

We have prioritized other work right now and this won't be picked up for a few more months. I first want to get /webrtc-direct in non experimental mode and then work on adding webrtc private to private.

I can help if someone is interested in working on this and landing this in.

Out of curiority, what do you need this for?

@2color
Copy link
Contributor

2color commented May 28, 2024

To reduce confusion (for myself and others), is this issue is solely focused on the WebRTC spec and not the WebRTC-Direct spec?

Can you confirm this @sukunrt?

@MarcoPolo
Copy link
Collaborator

@2color correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo
8 participants