Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: make metrics collection independent of Prometheus' scrape frequency #1429

Open
marten-seemann opened this issue Apr 5, 2021 · 2 comments

Comments

@marten-seemann
Copy link
Contributor

Looping over the connections on a fixed interval would make the data returned to Prometheus independent of its scrape interval and the amount of Prometheus instances. E.g. if you have 3 Prometheus instances for high availability, you would be looping over the connections 3 times every scrape interval (e.g. minute). Instead, if you collect on a fixed interval (e.g. 1 minute) you would only loop over all collections once per minute, instead of 3 times per minute.

I think it is fine either way.

Originally posted by @mxinden in libp2p/go-libp2p-quic-transport#200 (comment)

@marten-seemann
Copy link
Contributor Author

Open question: Is there any way to find out Prometheus' scrape frequency, so we can adjust our collection interval?

@mxinden
Copy link
Member

mxinden commented Apr 5, 2021

Open question: Is there any way to find out Prometheus' scrape frequency, so we can adjust our collection interval?

Not that I am aware of, other than guessing it based on previous scrapes, though I would consider that a hack.

@marten-seemann marten-seemann transferred this issue from libp2p/go-libp2p-quic-transport Apr 22, 2022
@marten-seemann marten-seemann changed the title make metrics collection independent of Prometheus' scrape frequency quic: make metrics collection independent of Prometheus' scrape frequency Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants