-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not filling mesh peers if there are less than D
of them when joining a topic
#194
Comments
Hey @vyzo, is there a misalignment between implementation and spec? |
it's a minor bug I would say. |
Please elaborate. OP probably wants to understand impact and where the bug is: in the spec or the implementation. |
The bug is in the implementation. |
@vyzo — let’s fix the implementation promptly. Several teams are using this as the reference implementation, and it creates confusion, despite the impact being minimal, in theory. |
Added some code to handle this in #196. |
What is wrong?
In
GossipSubRouter.Join()
if there are fanout peers but not enough of them, it won'tselects the remaining number of peers (D-x) from peers.gossipsub[topic]
as suggested in the spec.go-libp2p-pubsub/gossipsub.go
Lines 269 to 274 in 4221a39
The text was updated successfully, but these errors were encountered: