Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .pc file to NTL #7

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a .pc file to NTL #7

wants to merge 4 commits into from

Conversation

kiwifb
Copy link

@kiwifb kiwifb commented May 27, 2021

Adding a .pc file for NTL helps downstream applications and library to properly find the library and headers in a standard way.

@victorshoup
Copy link
Contributor

@kiwifb

Thanks for the PR! This looks quite reasonable. SInce this generates the file ntl.pc, I wonder if this should also be coordinated with the .gitignore PR.

@kiwifb
Copy link
Author

kiwifb commented Jun 6, 2021

It definitely should! Let me have a look at the PR.

@kiwifb
Copy link
Author

kiwifb commented Jun 6, 2021

OK, two ways of going about that:

  1. you merge the .gitignore PR, I rebase on it and add the bits for .pc
  2. You ask Matthias to add bits for .pc independently

Either way one of use will have to do a bit of extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants