Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug. when gmp version is 6.2.1 #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zjwangmin
Copy link

fix bug. when gmp version is bigger than 6.0.0. gmp current version is 6.2.1.

fix bug. when gmp version is bigger than 6.0.0. gmp current version is 6.2.1.
@victorshoup
Copy link
Contributor

Hi! Thanks for the PR. I'm not sure your modification makes sense. The point of that test is to check if the version number in the GMP header file is identical to that in the GMP binaries. If they are not, that is is a sign that there is some inconsistency in your system configuration. For example, you might have things set up so that the compiler sees certain header files, but you might not have environment variables set up to see the corresponding library a run time. So...I'm not sure that changing the comparison from != to < makes sense. But perhaps you have an argument to support your proposal...please let me know...I'd be happy to discuss!

@zjwangmin
Copy link
Author

zjwangmin commented May 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants