Skip to content

Commit 0c82fd3

Browse files
safrissafris
committed
Use -Double.MAX_VALUE
1 parent 7dabb7b commit 0c82fd3

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

‎src/main/java/org/libj/util/DiscreteTopologies.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -956,7 +956,7 @@ public int compare(final Long[] o1, final Long[] o2) {
956956
public static final DiscreteTopology<Float> FLOAT = new DiscreteTopology<Float>() {
957957
@Override
958958
public boolean isMinValue(final Float v) {
959-
return Float.MIN_VALUE == v;
959+
return -Float.MAX_VALUE == v;
960960
}
961961

962962
@Override
@@ -984,7 +984,7 @@ public int compare(final Float o1, final Float o2) {
984984
@Override
985985
public boolean isMinValue(final float[] v) {
986986
for (int i = 0, i$ = v.length; i < i$; ++i) // [A]
987-
if (v[i] != Float.MIN_VALUE)
987+
if (v[i] != -Float.MAX_VALUE)
988988
return false;
989989

990990
return true;
@@ -1005,7 +1005,7 @@ public float[] prevValue(final float[] v) {
10051005
int i = v.length - 1;
10061006
for (float a; i >= 0; --i) { // [A]
10071007
a = p[i];
1008-
if (Float.MIN_VALUE != a) {
1008+
if (-Float.MAX_VALUE != a) {
10091009
p[i] = Math.nextDown(a);
10101010
break;
10111011
}
@@ -1052,7 +1052,7 @@ public int compare(final float[] o1, final float[] o2) {
10521052
@Override
10531053
public boolean isMinValue(final Float[] v) {
10541054
for (int i = 0, i$ = v.length; i < i$; ++i) // [A]
1055-
if (v[i] != Float.MIN_VALUE)
1055+
if (v[i] != -Float.MAX_VALUE)
10561056
return false;
10571057

10581058
return true;
@@ -1073,7 +1073,7 @@ public Float[] prevValue(final Float[] v) {
10731073
int i = v.length - 1;
10741074
for (Float a; i >= 0; --i) { // [A]
10751075
a = p[i];
1076-
if (Float.MIN_VALUE != a) {
1076+
if (-Float.MAX_VALUE != a) {
10771077
p[i] = Math.nextDown(a);
10781078
break;
10791079
}
@@ -1119,7 +1119,7 @@ public int compare(final Float[] o1, final Float[] o2) {
11191119
public static final DiscreteTopology<Double> DOUBLE = new DiscreteTopology<Double>() {
11201120
@Override
11211121
public boolean isMinValue(final Double v) {
1122-
return Double.MIN_VALUE == v;
1122+
return -Double.MAX_VALUE == v;
11231123
}
11241124

11251125
@Override
@@ -1147,7 +1147,7 @@ public int compare(final Double o1, final Double o2) {
11471147
@Override
11481148
public boolean isMinValue(final double[] v) {
11491149
for (int i = 0, i$ = v.length; i < i$; ++i) // [A]
1150-
if (v[i] != Double.MIN_VALUE)
1150+
if (v[i] != -Double.MAX_VALUE)
11511151
return false;
11521152

11531153
return true;
@@ -1168,7 +1168,7 @@ public double[] prevValue(final double[] v) {
11681168
int i = v.length - 1;
11691169
for (double a; i >= 0; --i) { // [A]
11701170
a = p[i];
1171-
if (Double.MIN_VALUE != a) {
1171+
if (-Double.MAX_VALUE != a) {
11721172
p[i] = Math.nextDown(a);
11731173
break;
11741174
}
@@ -1215,7 +1215,7 @@ public int compare(final double[] o1, final double[] o2) {
12151215
@Override
12161216
public boolean isMinValue(final Double[] v) {
12171217
for (int i = 0, i$ = v.length; i < i$; ++i) // [A]
1218-
if (v[i] != Double.MIN_VALUE)
1218+
if (v[i] != -Double.MAX_VALUE)
12191219
return false;
12201220

12211221
return true;
@@ -1236,7 +1236,7 @@ public Double[] prevValue(final Double[] v) {
12361236
int i = v.length - 1;
12371237
for (Double a; i >= 0; --i) { // [A]
12381238
a = p[i];
1239-
if (Double.MIN_VALUE != a) {
1239+
if (-Double.MAX_VALUE != a) {
12401240
p[i] = Math.nextDown(a);
12411241
break;
12421242
}

‎src/test/java/org/libj/util/DiscreteTopologiesTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ private void testMax(final DiscreteTopology<N> t, final N max) {
119119
@SuppressWarnings({"rawtypes", "unchecked"})
120120
public void testMinMax() {
121121
final DiscreteTopology[] ts = {DiscreteTopologies.BYTE, DiscreteTopologies.SHORT, DiscreteTopologies.INTEGER, DiscreteTopologies.LONG, DiscreteTopologies.FLOAT, DiscreteTopologies.DOUBLE, DiscreteTopologies.CHARACTER, DiscreteTopologies.LOCAL_DATE, DiscreteTopologies.DATE};
122-
final Object[] mins = {Byte.MIN_VALUE, Short.MIN_VALUE, Integer.MIN_VALUE, Long.MIN_VALUE, Float.MIN_VALUE, Double.MIN_VALUE, Character.MIN_VALUE, LocalDate.MIN, Dates.MIN_VALUE};
122+
final Object[] mins = {Byte.MIN_VALUE, Short.MIN_VALUE, Integer.MIN_VALUE, Long.MIN_VALUE, -Float.MAX_VALUE, -Double.MAX_VALUE, Character.MIN_VALUE, LocalDate.MIN, Dates.MIN_VALUE};
123123
final Object[] maxs = {Byte.MAX_VALUE, Short.MAX_VALUE, Integer.MAX_VALUE, Long.MAX_VALUE, Float.MAX_VALUE, Double.MAX_VALUE, Character.MAX_VALUE, LocalDate.MAX, Dates.MAX_VALUE};
124124
for (int i = 0, i$ = ts.length; i < i$; ++i) // [A]
125125
MinMax.test(ts[i], mins[i], maxs[i]);
@@ -129,7 +129,7 @@ public void testMinMax() {
129129
@SuppressWarnings({"rawtypes", "unchecked"})
130130
public void testMinMaxArrayPrimitive() {
131131
final DiscreteTopology[] ts = {DiscreteTopologies.BYTES, DiscreteTopologies.SHORTS, DiscreteTopologies.INTS, DiscreteTopologies.LONGS, DiscreteTopologies.FLOATS, DiscreteTopologies.DOUBLES, DiscreteTopologies.CHARS};
132-
final Object[] mins = {Byte.MIN_VALUE, Short.MIN_VALUE, Integer.MIN_VALUE, Long.MIN_VALUE, Float.MIN_VALUE, Double.MIN_VALUE, Character.MIN_VALUE};
132+
final Object[] mins = {Byte.MIN_VALUE, Short.MIN_VALUE, Integer.MIN_VALUE, Long.MIN_VALUE, -Float.MAX_VALUE, -Double.MAX_VALUE, Character.MIN_VALUE};
133133
final Object[] maxs = {Byte.MAX_VALUE, Short.MAX_VALUE, Integer.MAX_VALUE, Long.MAX_VALUE, Float.MAX_VALUE, Double.MAX_VALUE, Character.MAX_VALUE};
134134
for (int i = 0, i$ = ts.length; i < i$; ++i) { // [A]
135135
for (int j = 0; j < 100; j = j * 2 + 1) { // [A]
@@ -152,7 +152,7 @@ public void testMinMaxArrayPrimitive() {
152152
@SuppressWarnings({"rawtypes", "unchecked"})
153153
public void testMinMaxArrayObject() {
154154
final DiscreteTopology[] ts = {DiscreteTopologies.BYTE_OBJS, DiscreteTopologies.SHORT_OBJS, DiscreteTopologies.INTEGERS, DiscreteTopologies.LONG_OBJS, DiscreteTopologies.FLOAT_OBJS, DiscreteTopologies.DOUBLE_OBJS, DiscreteTopologies.CHARACTERS};
155-
final Object[] mins = {Byte.MIN_VALUE, Short.MIN_VALUE, Integer.MIN_VALUE, Long.MIN_VALUE, Float.MIN_VALUE, Double.MIN_VALUE, Character.MIN_VALUE};
155+
final Object[] mins = {Byte.MIN_VALUE, Short.MIN_VALUE, Integer.MIN_VALUE, Long.MIN_VALUE, -Float.MAX_VALUE, -Double.MAX_VALUE, Character.MIN_VALUE};
156156
final Object[] maxs = {Byte.MAX_VALUE, Short.MAX_VALUE, Integer.MAX_VALUE, Long.MAX_VALUE, Float.MAX_VALUE, Double.MAX_VALUE, Character.MAX_VALUE};
157157
for (int i = 0, i$ = ts.length; i < i$; ++i) { // [A]
158158
for (int j = 0; j < 100; j = j * 2 + 1) { // [A]
@@ -193,7 +193,7 @@ public void testMinMaxArray() {
193193
@Test
194194
public void testString() {
195195
for (int i = 0; i < 100; i = i * 2 + 1) // [N]
196-
MinMax.test(DiscreteTopologies.STRING, Strings.repeat(Character.MIN_VALUE, i), Strings.repeat(Character.MAX_VALUE, i));
196+
MinMax.test(DiscreteTopologies.STRING, Strings.repeat(Character.MIN_VALUE, i).toString(), Strings.repeat(Character.MAX_VALUE, i).toString());
197197
}
198198

199199
@Test

0 commit comments

Comments
 (0)