-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.9.0 #536
Comments
Wow, some of those changes have been sitting around for a while. Thanks for bringing this up, @pietbrauer! |
I created a 0.8.9 release (https://github.com/libgit2/objective-git/releases/tag/0.8.9) but I haven't been able to create a binary for it. When I try, I get:
Possibly the same as SwiftJSON is seeing: SwiftyJSON/SwiftyJSON#327 (comment)? Any ideas? Anyone else able to create a binary? ( |
Sweet, can try tomorrow. Why 0.8.9 though? Isn't the |
Good point. I was thinking it was just fixing a bug, but I guess it does break anyone who was using it. 👍 Updated to be 0.9. |
With
|
Ah interesting. So that gets me a bit further, and then a lot of errors like:
|
I don't get these errors building with Xcode 7.2 and carthage 0.11.0 (on OS X 10.11.2) using the following command:
Build log: https://gist.github.com/phatblat/e6525b198bff64dfa738 |
¯_(ツ)_/¯ I uploaded that build. Thanks to you both! |
A couple differences between that .zip file and the 0.8.8 release:
|
So should I remove the binary? |
I don't think either of these are problems. The README states:
As for codesign, iOS apps need to sign embedded frameworks anyway before deployment. I'm not sure about Mac apps. So, I think the file I provided is fine, just not 100% sure since I typically build ObjectiveGit from source. @pietbrauer lmk if you have any problems with the new build. |
Works, thanks guys! Such a bliss to work with it in Swift now. |
👍🏼 |
@phatblat Why did you strip the symbols out? It's only 5 MB difference, going from 10 MB to 15 MB? |
Before i zipped up the Carthage build dir, I removed the Quick and Nimble framework builds and took the .dSYM files out too. Together, the symbols for both platforms were 18MB before compression. We didn't used to include them, which is why I added that section to the README about including debug symbols. Additionally, I provided a Release build which doesn't make for a deterministic debugging experience |
It was only after @joshaber posted the build that I compared it to the 0.8.8 release and noticed those differences. I didn't see them as a problem but figured I'd mention them in case someone else called for a rebuild. Are you needing them for debugging into the framework? If so, I think you're better off building the framework with the Debug config which will give you symbol files too. Note that I've had to add the ObjectiveGit project to my app's xcworkspace to get Xcode to even try to show me source while debugging. |
That's because Carthage didn't use to include them in releases. |
Yeah, when I use. |
IMHO, it's worth it to set up the config to build from source. That way, you could point to your branch/fork to test a change, or do something fancy like |
|
Release a new version: 0.9.0
Changeling (Comparison)
NS_OPTIONS
(Adjusted GTMergeAnalysis type #522). Thanks @slavikus!isGitDirectory:
(RemoveisAGitDirectory:
#527). Thanks @pietbrauer!moveHEAD
(Fix libssh2 inclusion in libgit2 iOS build script #533). Thanks @phatblat!The text was updated successfully, but these errors were encountered: